Open issues

Implement conversion method for string-based configurations.

Description

A recent refactoring improved the configuration classes so that anything extending BaseConfiguration<T> has a convertValue(@Nonnull final Optional<T> value, @Nonnull final Class<C> convertClass) method for converting from the underlying storage values to the requested type. However it appears that even though AbstractStringConfiguration now extends BaseConfiguration, it wasn't completely updated to use convertValue(); its values are still being converted in findObject(final String key, final Class<O> type).

Move the conversion logic in from AbstractStringConfiguration from findObject() to convertValue() so that the conversion logic can be consolidated and reused. Moreover after this change AbstractStringConfiguration.findObject() can probably be removed altogether, allowing the implementation from BaseConfiguration to be used (which calls convertValue()).

Environment

None

Status

Assignee

Garret Wilson

Reporter

Garret Wilson

Labels

None

Fix versions

Priority

Critical
Configure