`Files.deleteFileTree()` should be idempotent.

Description

I ran into a situation where com.globalmentor.io.Files.deleteFileTree(Path) failed when the Path did not exist. Irrespective of the behavior of File.delete(), the deleteFileTree() method should not return any sort of error if the tree has already been deleted. Whether there is a check up-front, any missing-path exception should be caught and ignored to handle the race condition. Unit (integration?) tests need to be added.

Environment

None

Linked work items

relates to

JAVA-312

Option to force deletion of read-only files for file subtrees.

Activity

Garret Wilson

June 7, 2023 at 1:56 PM

At some point Files.delete(File file, boolean recursive) was marked as deprecated in favor of deleteFileTree(@Nonnull final Path fileTreeRoot) . The former may have been deprecated because (according to the API documentation) it follows symbolic links. Maybe both should be present for completeness. In any case, for the latter, there is a java.nio.file.deleteIfExists(Path path), so perhaps naming this java.nio.file.deleteIfExists(Path path, boolean recursive) would be more appropriate.

Resize work item view side panel

Fixed

Details

Assignee

Garret Wilson

Reporter

Garret Wilson

Priority

Critical

Created October 7, 2022 at 3:25 PM

Updated June 12, 2023 at 8:12 PM

Resolved June 7, 2023 at 5:13 PM

`Files.deleteFileTree()` should be idempotent.

Description

Environment

Linked work items

relates to

Activity

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority